Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16741 vos: Avoid race condition with discard #15370

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

jolivier23
Copy link
Contributor

There is a possible race between aggregation deleting the object tree and discard working on the same
object tree. Add a check to avoid this race

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

There is a possible race between aggregation deleting
the object tree and discard working on the same
object tree.  Add a check to avoid this race

Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
Copy link

github-actions bot commented Oct 22, 2024

Ticket title is 'Possible race between aggregation and object discard'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16741

@jolivier23 jolivier23 changed the title DAOS-16211 vos: Avoid race condition with discard DAOS-16741 vos: Avoid race condition with discard Oct 23, 2024
@jolivier23 jolivier23 marked this pull request as ready for review October 24, 2024 13:10
@jolivier23 jolivier23 requested review from a team as code owners October 24, 2024 13:10
@jolivier23 jolivier23 merged commit bf494ea into master Oct 29, 2024
56 checks passed
@jolivier23 jolivier23 deleted the jvolivie/assert branch October 29, 2024 14:54
jolivier23 added a commit that referenced this pull request Oct 30, 2024
There is a possible race between aggregation deleting
the object tree and discard working on the same
object tree.  Add a check to avoid this race

Signed-off-by: Jeff Olivier <[email protected]>
jolivier23 added a commit that referenced this pull request Oct 30, 2024
There is a possible race between aggregation deleting
the object tree and discard working on the same
object tree.  Add a check to avoid this race

Signed-off-by: Jeff Olivier <[email protected]>
gnailzenh pushed a commit that referenced this pull request Nov 5, 2024
* DAOS-16211 vos: Avoid race condition with discard (#15370)

There is a possible race between aggregation deleting
the object tree and discard working on the same
object tree.  Add a check to avoid this race

Signed-off-by: Jeff Olivier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants